Project

General

Profile

Bugless #49

kartongips: remove deprecated diff-strategy flag

Added by q3k over 2 years ago. Updated over 1 year ago.

Status:
Assigned
Priority:
Normal
Assignee:
Category:
hscloud

Description

Over in https://gerrit.hackerspace.pl/1087 , we deprecate the --diff-strategy flag and set the default behaviour to subset.

This is tracking issues to remove this flag after some time has passed and no-one complains that they relied on the old behaviour.

Current deadline is `date` + 3mo, ie. December 11, 2021.

#1

Updated by q3k over 2 years ago

Rationale for setting the default strategy to subset: it's the only mode I use, the only mode I see others use, and pretty much the behavior people seem to want. For some reason (backwards compat in upstream kubecfg?) it is not the default.

It's also weirdly named, as it's not strictly acting on a subset (especially now that we do things like handling aggregated ClusterRoles).

My plan is to instead have one default sane behaviour of `kartongips diff`, be it via the current 'subset' codepath or by moving kubecfg over to use server-side apply and/or even backing it in kubectl diff.

#2

Updated by informatic about 2 years ago

In may of 2021 last-applied strategy (based on serialized config stored in kubecfg.ksonnet.io/last-applied-configuration annotation - one that is already pushed in the version we have) has been introduced. It seems to work fairly well, based on testing in some of my personal projects.
https://github.com/vmware-archive/kubecfg/commit/31781f22b0d390f2e122e8deff798aabbc3d52d5

#3

Updated by q3k over 1 year ago

  • Category set to hscloud

Also available in: Atom PDF